[ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830276#comment-15830276 ]
Rohith Sharma K S commented on YARN-4675: ----------------------------------------- bq. i have tried to maintain V1 client as it is and change only V2 client, so that we can have modifications in trunk as well branch-2. Please share your thoughts on the same. As long as org.apache.hadoop.yarn.client.api.TimelineClient is abstracted and maintain compatibility for users, then we can commit to branch-2 as well. Btw, I have not seen patch yet, I will take a look. > Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl > -------------------------------------------------------------------- > > Key: YARN-4675 > URL: https://issues.apache.org/jira/browse/YARN-4675 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Labels: YARN-5355, yarn-5355-merge-blocker > Attachments: YARN-4675.v2.002.patch, YARN-4675.v2.003.patch, > YARN-4675-YARN-2928.v1.001.patch > > > We need to reorganize TimeClientImpl into TimeClientV1Impl , > TimeClientV2Impl and if required a base class, so that its clear which part > of the code belongs to which version and thus better maintainable. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org