[ 
https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762866#comment-15762866
 ] 

Naganarasimha G R commented on YARN-4675:
-----------------------------------------

Thanks for the discussion  [~sjlee0], [~gtCarrera9] and [~varun_saxena] and 
sorry for the delay.
few clarifications in the finalized approach:
# So we have finalized that there will be 2 different interfaces for ATSv1(& 
1.5) and ATSV2, So shall i name the new interface for V2 as 
{{TimelineV2Client}} and impl as {{TimelineV2ClientImpl}} ?
# {{TimelineV2Client.createTimelineClient}} would this interface be fine to get 
the v2 instance ?


> Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
> --------------------------------------------------------------------
>
>                 Key: YARN-4675
>                 URL: https://issues.apache.org/jira/browse/YARN-4675
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>              Labels: YARN-5355, yarn-5355-merge-blocker
>         Attachments: YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,  
> TimeClientV2Impl and if required a base class, so that its clear which part 
> of the code belongs to which version and thus better maintainable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to