[
https://issues.apache.org/jira/browse/YARN-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837017#comment-15837017
]
Jonathan Hung commented on YARN-5734:
-------------------------------------
[~leftnoteasy] thanks for the review. Regarding 1 and 3, potentially there are
queue admins (but not yarn admins) that will change scheduler configuration. In
this case the AdminService will not check (yarn admin) acls, it should delegate
it to ConfigurationMutationPolicy. With this in mind do you still think
AdminService is the right place to put the change configuration functionality?
For 3, I will add javadocs and a default implementation of the
ConfigurationMutationPolicy (which will just check against queue admin acls).
(YARN-5954)
Regarding 2, do you mean a separate configuration provider
(MutableConfigurationManager) for CS, and
{{yarn.resourcemanager.configuration.provider-class}} for everything else? As
it is now, I made a mistake in the current patch, we can actually take
-Provider out of RMContext, since
{{yarn.resourcemanager.configuration.provider-class}} is
MutableConfigurationManager, so we can just access it via
rmContext.getConfigurationProvider(). If we make MutableConfigurationManager
part of CS only, the ClientRMService/AdminService still needs to access it
somehow. Also to avoid having to change it in other places, currently
MutableConfigurationManager overrides LocalConfigurationProvider, so the
getConfigurationInputStream behavior in all other non-CS places should be the
same. As long as MutableConfigurationManager does not overwrite this
functionality we can load stuff from {{yarn-site}}, etc in the same way. (Also
in the future if we add store functionality to other non-CS configurations we
can just do this through the configuration provider.) Thoughts on this?
> OrgQueue for easy CapacityScheduler queue configuration management
> ------------------------------------------------------------------
>
> Key: YARN-5734
> URL: https://issues.apache.org/jira/browse/YARN-5734
> Project: Hadoop YARN
> Issue Type: New Feature
> Reporter: Min Shen
> Assignee: Min Shen
> Attachments: OrgQueue_API-Based_Config_Management_v1.pdf,
> OrgQueueAPI-BasedSchedulerConfigurationManagement_v2.pdf,
> OrgQueue_Design_v0.pdf, YARN-5734-YARN-5734.001.patch
>
>
> The current xml based configuration mechanism in CapacityScheduler makes it
> very inconvenient to apply any changes to the queue configurations. We saw 2
> main drawbacks in the file based configuration mechanism:
> # This makes it very inconvenient to automate queue configuration updates.
> For example, in our cluster setup, we leverage the queue mapping feature from
> YARN-2411 to route users to their dedicated organization queues. It could be
> extremely cumbersome to keep updating the config file to manage the very
> dynamic mapping between users to organizations.
> # Even a user has the admin permission on one specific queue, that user is
> unable to make any queue configuration changes to resize the subqueues,
> changing queue ACLs, or creating new queues. All these operations need to be
> performed in a centralized manner by the cluster administrators.
> With these current limitations, we realized the need of a more flexible
> configuration mechanism that allows queue configurations to be stored and
> managed more dynamically. We developed the feature internally at LinkedIn
> which introduces the concept of MutableConfigurationProvider. What it
> essentially does is to provide a set of configuration mutation APIs that
> allows queue configurations to be updated externally with a set of REST APIs.
> When performing the queue configuration changes, the queue ACLs will be
> honored, which means only queue administrators can make configuration changes
> to a given queue. MutableConfigurationProvider is implemented as a pluggable
> interface, and we have one implementation of this interface which is based on
> Derby embedded database.
> This feature has been deployed at LinkedIn's Hadoop cluster for a year now,
> and have gone through several iterations of gathering feedbacks from users
> and improving accordingly. With this feature, cluster administrators are able
> to automate lots of thequeue configuration management tasks, such as setting
> the queue capacities to adjust cluster resources between queues based on
> established resource consumption patterns, or managing updating the user to
> queue mappings. We have attached our design documentation with this ticket
> and would like to receive feedbacks from the community regarding how to best
> integrate it with the latest version of YARN.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
