[ 
https://issues.apache.org/jira/browse/YARN-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702532#comment-13702532
 ] 

Omkar Vinit Joshi commented on YARN-814:
----------------------------------------

* Instead of putting string messages of where this log came from we can use 
log4j L option if suitable/required.
[http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html]
similarly other LOG.warn places.
{code}
-      LOG.warn("Exit code from container is : " + exitCode);
+      LOG.warn("Exit code from LinuxContainerExecutor's deleteAsUser is : " + 
exitCode);
{code}

* I guess it will be more helpful if we add containerId there.. (locId = 
containerId)

rest of the patch looks good.

                
> Difficult to diagnose a failed container launch when error due to invalid 
> environment variable
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-814
>                 URL: https://issues.apache.org/jira/browse/YARN-814
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Jian He
>         Attachments: YARN-814.1.patch, YARN-814.2.patch, YARN-814.3.patch, 
> YARN-814.4.patch, YARN-814.patch
>
>
> The container's launch script sets up environment variables, symlinks etc. 
> If there is any failure when setting up the basic context ( before the actual 
> user's process is launched ), nothing is captured by the NM. This makes it 
> impossible to diagnose the reason for the failure. 
> To reproduce, set an env var where the value contains characters that throw 
> syntax errors in bash. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to