[jira] [Commented] (YARN-814) Difficult to diagnose a failed container launch when error due to invalid environment variable

[Omkar Vinit Joshi (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735355#comment-13735355
 ] 

Omkar Vinit Joshi commented on YARN-814:
----------------------------------------

We forgot to fix one issue ..fixing it in another ticket. from 
ContainerImpl.java.. we are ignoring diagnostic messages...
{code}
  /**
   * Transitions upon receiving KILL_CONTAINER:
   * - LOCALIZED -> KILLING
   * - RUNNING -> KILLING
   */
  @SuppressWarnings("unchecked") // dispatcher not typed
  static class KillTransition implements
      SingleArcTransition<ContainerImpl, ContainerEvent> {
    @Override
    public void transition(ContainerImpl container, ContainerEvent event) {
      // Kill the process/process-grp
      container.dispatcher.getEventHandler().handle(
          new ContainersLauncherEvent(container,
              ContainersLauncherEventType.CLEANUP_CONTAINER));
      ContainerKillEvent killEvent = (ContainerKillEvent) event;
    }
  }

  /**
   * Transition from KILLING to CONTAINER_CLEANEDUP_AFTER_KILL
   * upon receiving CONTAINER_KILLED_ON_REQUEST.
   */
  static class ContainerKilledTransition implements
      SingleArcTransition<ContainerImpl, ContainerEvent> {
    @Override
    public void transition(ContainerImpl container, ContainerEvent event) {
      ContainerExitEvent exitEvent = (ContainerExitEvent) event;
      container.exitCode = exitEvent.getExitCode();

      // The process/process-grp is killed. Decrement reference counts and
      // cleanup resources
      container.cleanup();
    }
  }
{code}
                
> Difficult to diagnose a failed container launch when error due to invalid 
> environment variable
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-814
>                 URL: https://issues.apache.org/jira/browse/YARN-814
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Jian He
>             Fix For: 2.1.0-beta
>
>         Attachments: YARN-814.1.patch, YARN-814.2.patch, YARN-814.3.patch, 
> YARN-814.4.patch, YARN-814.5.patch, YARN-814.6.patch, YARN-814.7.patch, 
> YARN-814.patch
>
>
> The container's launch script sets up environment variables, symlinks etc. 
> If there is any failure when setting up the basic context ( before the actual 
> user's process is launched ), nothing is captured by the NM. This makes it 
> impossible to diagnose the reason for the failure. 
> To reproduce, set an env var where the value contains characters that throw 
> syntax errors in bash. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira