[
https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868628#comment-15868628
]
Varun Saxena commented on YARN-6069:
------------------------------------
Thanks [~rohithsharma] for the patch.
# I think we can move CrossOriginFilterInitializer to hadoop-yarn-server-common
to avoid code duplication. Both AHS and ATSv2 will use the same piece of code.
You are additionally checking for CORS enabled and printing a message in ATSv2
but same change should be fine for AHS too.
# We dont need to override getEnabledConfigKey. Base class method is protected
hence would be accessible and it also calls the method getPrefix() so it will
get the correct prefix. Consequently, we do not need the field ENABLED_SUFFIX
in CrossOriginFilterInitializer.
# getPrefix method can simply return PREFIX. No need of accessing it via
classname as local variable is accessible.
# PREFIX can be private.
# Checkstyle can be fixed as well.
> CORS support in timeline v2
> ---------------------------
>
> Key: YARN-6069
> URL: https://issues.apache.org/jira/browse/YARN-6069
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Sreenath Somarajapuram
> Assignee: Rohith Sharma K S
> Attachments: YARN-6069-YARN-5355.0001.patch
>
>
> By default the browser prevents accessing resources from multiple domains. In
> most cases the UIs would be loaded form a domain different from that of
> timeline server. Hence without CORS support, it would be difficult for the
> UIs to load data from timeline v2.
> YARN-2277 must provide more info on the implementation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
