[ https://issues.apache.org/jira/browse/YARN-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869084#comment-15869084 ]
Varun Saxena commented on YARN-6069: ------------------------------------ bq. I think you are missing one key thing is PREFIX is different i.e yarn.timeline-service.http-cross-origin which is same as ATSv1. Sorry did not get you. The config used for ATSv2 is same as ATSv1 so we can use the same class. Right? Infact if configurations were different my comment would have been to keep them the same. We reuse configurations across ATSv1 and ATSv2. Hence I suggested to move CrossOriginFilterInitializer to hadoop-yarn-server-common and let ATSv1(hadoop-yarn-server-applicationhistoryservice package) and ATSv2(hadoop-yarn-server-timelineservice package) refer to it. bq. May be I can remove class CrossOriginFilterInitializer and keep HttpCrossOriginFilterInitializer itself for ATSv2 The reason we have CrossOriginFilterInitializer which extends HttpCrossOriginFilterInitializer is to override sibling configurations of HttpCrossOriginFilterInitializer with specific timeline service configurations. So we would need to have a derived class. Right? > CORS support in timeline v2 > --------------------------- > > Key: YARN-6069 > URL: https://issues.apache.org/jira/browse/YARN-6069 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelinereader > Reporter: Sreenath Somarajapuram > Assignee: Rohith Sharma K S > Attachments: YARN-6069-YARN-5355.0001.patch > > > By default the browser prevents accessing resources from multiple domains. In > most cases the UIs would be loaded form a domain different from that of > timeline server. Hence without CORS support, it would be difficult for the > UIs to load data from timeline v2. > YARN-2277 must provide more info on the implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org