[ 
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871122#comment-15871122
 ] 

Rohith Sharma K S commented on YARN-6027:
-----------------------------------------

bq. On a related note, how would the client provide the value for fromId? Does 
it need to compose the fromId, or can we add a UID for flow activity in the 
info and they can just grab and send it as fromId? I thought we were doing 
something like that for other pagination? If it is the latter, then can we not 
use FLOW_UID for this?
To the flowActivity, fromId can NOT be single value since these are tracked by 
daily basis!! FromId which user provides has to be complete row key. I wanted 
to used flow entity id itself as fromId because user can provide just pick the 
flow entity id and send it as fromId. Note that flow entity id has complete row 
key values. But flow entity id is not escaped as flow_UID is done. FLOW_UID 
does not have time values in it e.g {{"UID": "yarn-cluster!rohithsharmaks!Sleep 
job"}}. May be FLOW_UID itself can be changed to add timestamp and use it as 
fromId. 

> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
>                 Key: YARN-6027
>                 URL: https://issues.apache.org/jira/browse/YARN-6027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6027-YARN-5355.0001.patch, 
> YARN-6027-YARN-5355.0002.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar 
> filter for flows/flowRun apps and flow run and flow as well. 
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates 
> found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to