[ 
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871517#comment-15871517
 ] 

Rohith Sharma K S commented on YARN-6027:
-----------------------------------------

I would be more leaning towards adding new field FROM_ID rather than re using 
UID. May be we need to add FROM_ID field in all the API's so that user can 
directly pick it up and provide it as fromId. 
If I look at UID encode/decode implementations, it always expect 
TimelineReaderContext as parameter and return type. But all the UID encoding 
does not happen with row key say UID {{"UID": 
"yarn-cluster!application_1484113378396_0001"}}. Instead of using UID, new 
field always FROM_ID is always better I feel. I will update v0 patch for 
proposal, let discuss on v0 patch. 

> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
>                 Key: YARN-6027
>                 URL: https://issues.apache.org/jira/browse/YARN-6027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6027-YARN-5355.0001.patch, 
> YARN-6027-YARN-5355.0002.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar 
> filter for flows/flowRun apps and flow run and flow as well. 
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates 
> found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to