[ https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703665#comment-13703665 ]
Karthik Kambatla commented on YARN-353: --------------------------------------- Few comments/nits before we get this in: # Add test to check the disconnect and reconnect logic, essentially the switch-cases in processWatchEvent # YarnConfiguration: how about creating a common prefix for all of zk-state-store related parameters? # Make the ZKRMStateStore#NUM_RETRIES configurable with default set to 3. # ZKRMStateStore#getNewZooKeeper need not be synchronized # Might be cleaner to move zkDoWithRetries to ZkAction # Just thinking out loud: would it make sense to move the *WithRetries methods to ZkAction itself, and may be rename it if required. All of the methods seem like util methods and moving them out might make it more readable > Add Zookeeper-based store implementation for RMStateStore > --------------------------------------------------------- > > Key: YARN-353 > URL: https://issues.apache.org/jira/browse/YARN-353 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Hitesh Shah > Assignee: Bikas Saha > Attachments: YARN-353.1.patch, YARN-353.2.patch, YARN-353.3.patch, > YARN-353.4.patch, YARN-353.5.patch > > > Add store that write RM state data to ZK -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira