[ 
https://issues.apache.org/jira/browse/YARN-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878866#comment-15878866
 ] 

Haibo Chen commented on YARN-4985:
----------------------------------

Sorry for missing your question, [~sjlee0]. One one hand, FlowScanner needs the 
byte representation of FlowRunColumn FlowRunColumnPrefix and their 
ValueConverters. Because these getter methods are defined in the 
superclass/interface, changing them means changing all their sibling classes. 
On the other hand, FlowScanner also depends on AggregationOperation and 
AggregationCompactionDimension, which are used extensively by hbase-client side 
code as well. Based on the two observations, I think having a new common module 
is probably easier than trying to move coprocessor dependencies into 
hbase-server module.

> Refactor the coprocessor code & other definition classes into independent 
> packages
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-4985
>                 URL: https://issues.apache.org/jira/browse/YARN-4985
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Vrushali C
>            Assignee: Haibo Chen
>              Labels: YARN-5355
>         Attachments: YARN-4985-YARN-5355.poc.patch, 
> YARN-4985-YARN-5355.prelim.patch
>
>
> As part of the coprocessor deployment, we have realized that it will be much 
> cleaner to have the coprocessor code sit in a package which does not depend 
> on hadoop-yarn-server classes. It only needs hbase and other util classes.
> These util classes and tag definition related classes can be refactored into 
> their own independent "definition" class package so that making changes to 
> coprocessor code, upgrading hbase, deploying hbase on a different hadoop 
> version cluster etc all becomes operationally much easier and less error 
> prone to having different library jars etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to