[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890033#comment-15890033
]
Varun Saxena commented on YARN-6027:
------------------------------------
Thanks [~rohithsharma] for the patch.
You have turned FlowActivityRowKeyConverter object inside FlowActivityRowKey to
static which would mean its one instance per class. We made a conscious
decision in YARN-5170 to eliminate singletons so I would not change this here.
In decode flow, I understand that we will create key converter objects multiple
times (i.e. equivalent to number of rows returned) which means more objects
which are created and which have to be garbage collected. But key converters
are lightweight objects so it may not have much impact. Also, we do that(create
multiple times) for row key objects as well which are slightly more
heavyweight. Probably we can avoid creating row key converters by creating a
row key instance in entity reader(s) and reusing them. Anyways we do not know
if this causes any big issue as of now.
So let us not change it in this JIRA. If you think this needs to be changed, we
can raise a new JIRA and discuss pros and cons.
Javadoc over KeyConverterToString, I would rather say "Interface which has to
be implemented for encoding and decoding row keys or column qualifiers as
string.". Over encode and decode method simply mention encodes/decodes key as
string (or also mention about column qualifiers).
For the javadoc over decode in the same interface I would say "Decode row key
from string to a key of type T." instead of to an object.
Was wondering if we can use {{@value}} tag to fetch default separator char
instead of hardcoding ! in comment over getRowKeyAsString but then we hardcode
this at multiple places. So lets leave it as it is.
I think the patch is good to go once checkstyle issues and comments above (bar
the last comment) are fixed.
I will raise a separate JIRA for findbugs issue. Not sure why that's coming.
> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
> Key: YARN-6027
> URL: https://issues.apache.org/jira/browse/YARN-6027
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6027-YARN-5355.0001.patch,
> YARN-6027-YARN-5355.0002.patch, YARN-6027-YARN-5355.0003.patch,
> YARN-6027-YARN-5355.0004.patch, YARN-6027-YARN-5355.0005.patch,
> YARN-6027-YARN-5355.0006.patch, YARN-6027-YARN-5355.0007.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar
> filter for flows/flowRun apps and flow run and flow as well.
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates
> found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
