[ 
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923495#comment-15923495
 ] 

Yufei Gu commented on YARN-6326:
--------------------------------

Thanks [~rkanter] for the review. Uploaded a new patch for your comments. I 
found it makes more sense to add a method for {{YarnScheduler}} to get an 
application by appId instead of changing {{ResourceScheduler}} to 
{{AbstractYarnScheduler}}.

> Shouldn't use AppAttemptIds to fetch applications while AM Simulator tracks 
> app in SLS
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-6326
>                 URL: https://issues.apache.org/jira/browse/YARN-6326
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler-load-simulator
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-6326.001.patch, YARN-6326.002.patch
>
>
> This causes a NPE issue. Beside the NPE, the metrics won't reflect the 
> different attempts. We should pass ApplicationId Instead of AppAttemptId. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to