[ 
https://issues.apache.org/jira/browse/YARN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705924#comment-13705924
 ] 

Sandy Ryza commented on YARN-521:
---------------------------------

bq. However, I will be cautious about making changes to the API because once we 
release it in the beta then it will be hard to change them.
I 100% agree that we should take the time to get this right the first time, as 
it will hopefully be used extensively and far down the road. I appreciate you 
helping me work through this.

bq. The method is supposed to give me requests that I can assign based on the 
parameters of priority, capability and location.
I see.  In that case your solution makes sense to me.  Essentially, it would 
never make sense to call getMatchingRequests at *-level when 
locality-relaxation is turned on, right?

bq. Looks like we have forgotten StoredContainerRequest in these changes. Its 
constructor also needs to account for the new flag.
I'll add that in.

Here's a stab at enumerating all the safe cases:
ContainerRequests without locality relaxation may contain multiple racks and 
multiple nodes, but must contain at least one of one of them. Requests with 
locality relaxation off may not coexist at the same priority as requests with 
locality relaxation on.  Multiple requests without locality relaxation may 
coexist at the same priority if any of the following are true:
* All the requests specify only nodes
* All the requests specify only racks
* All the requests specify the corresponding rack for each node they specify
* For any requests that specify nodes without their corresponding racks, no 
other requests specify those racks
                
> Augment AM - RM client module to be able to request containers only at 
> specific locations
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-521
>                 URL: https://issues.apache.org/jira/browse/YARN-521
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-521-1.patch, YARN-521-2.patch, YARN-521-2.patch, 
> YARN-521-3.patch, YARN-521.patch
>
>
> When YARN-392 and YARN-398 are completed, it would be good for AMRMClient to 
> offer an easy way to access their functionality

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to