[ 
https://issues.apache.org/jira/browse/YARN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708165#comment-13708165
 ] 

Bikas Saha commented on YARN-521:
---------------------------------

Your phrasing of cases in the comments above is a lot shorter and simpler to 
understand than the phrasing in the patch IMO. I would go with that. I can help 
make some changes before I commit.
To be clear, a strict request with {host1+rack1, host2} is valid? rack2 will be 
inferred and will have false set whereas rack1 will have true set for the flag. 
Thats what it looks like from the code and is probably correct logical behavior.

I was going to commit this when I saw the test failure above. I tried to debug 
it locally in eclipse but it ran fine. The failure is in the new test code. So 
I will wait for you to take a look.
                
> Augment AM - RM client module to be able to request containers only at 
> specific locations
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-521
>                 URL: https://issues.apache.org/jira/browse/YARN-521
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-521-1.patch, YARN-521-2.patch, YARN-521-2.patch, 
> YARN-521-3.patch, YARN-521-4.patch, YARN-521.patch
>
>
> When YARN-392 and YARN-398 are completed, it would be good for AMRMClient to 
> offer an easy way to access their functionality

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to