[ https://issues.apache.org/jira/browse/YARN-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941316#comment-15941316 ]
Yufei Gu commented on YARN-6380: -------------------------------- Redundancy is evil. Thanks for fixing this. Would you mind fixing the casting in getHeadRoom() since we are here? {code} public Resource getHeadroom() { final FSQueue queue = (FSQueue) this.queue; {code} > FSAppAttempt keeps redundant copy of the queue > ---------------------------------------------- > > Key: YARN-6380 > URL: https://issues.apache.org/jira/browse/YARN-6380 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Affects Versions: 3.0.0-alpha2 > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Attachments: YARN-6380.001.patch, YARN-6380.002.patch > > > The {{FSAppAttempt}} class defines its own {{fsQueue}} variable that is a > second copy of the {{SchedulerApplicationAttempt}}'s {{queue}} variable. > Aside from being redundant, it's also a bug, because when moving > applications, we only update the {{SchedulerApplicationAttempt}}'s {{queue}}, > not the {{FSAppAttempt}}'s {{fsQueue}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org