[ 
https://issues.apache.org/jira/browse/YARN-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707548#comment-13707548
 ] 

Hitesh Shah commented on YARN-865:
----------------------------------

{code}
if (!applicationTypes.isEmpty() && applicationTypes != null)
{code}
  - please fix the above. 

  - should split only be used if "," is found? 
  - can an entry in the set be null?
  - no tests for comma-separated list of app types?
     - in most test cases, the asserts are the same - it seems like there is 
not enough test data to actually verify whether filtering is working correctly? 

{code}
+  The applicationTypes parameter allows you to filter the applications. For 
example, one could request all applications whose applicationType is MAPREDUCE 
with  /apps?applicationTypes=MAPREDUCE. If applicationTypes parameter is not 
specified, it defaults to all applications.
+  To specify multiple applicationTypes, there are several options:
+  1) with /apps?applicationTypes=type1&applicationTypes=type2
+  2) with /apps?applicationTypes=type1,type2 (Use comma as Delimiter)
+  3) with /apps?applicationTypes=type1,type2&applicationTypes=type3
{code}
  - the above is not needed and likely confusing for users. There should be 
only one documented way of using the api. It can be removed in favor of the 
below suggestion:

{code}
+  * applicationTypes - applications matching the given application types, 
specified as a comma-separated list.
{code}








 

 
                
> RM webservices can't query based on application Types
> -----------------------------------------------------
>
>                 Key: YARN-865
>                 URL: https://issues.apache.org/jira/browse/YARN-865
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: MR-5337.1.patch, YARN-865.1.patch, YARN-865.2.patch, 
> YARN-865.3.patch, YARN-865.4.patch
>
>
> The resource manager web service api to get the list of apps doesn't have a 
> query parameter for appTypes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to