[
https://issues.apache.org/jira/browse/YARN-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13711574#comment-13711574
]
Zhijie Shen commented on YARN-865:
----------------------------------
The patch looks almost fine except the following:
{code}
+ if (applicationType.indexOf(",") == -1) {
+ appTypes.add(applicationType.trim());
+ } else {
{code}
It seems there's no need to do the additional testing of containing ",",
doesn't it? If applicationTypes = "Test Type", applicationTypes.split(",") will
generate ["Test Type"], an array of a single string. In addition, I don't think
there will be big performance difference given the short applicationTypes.
Moreover, I'm not opposed to the flexibility of applicationTypes params, and
the patch should work fine, but IMHO, either "applicationTypes=type1,type2" or
"applicationType=type1&applicationType=type2" should be enough. Reasonable
users rarely take advantage of this flexibility to construct their URLs, do
they?
> RM webservices can't query based on application Types
> -----------------------------------------------------
>
> Key: YARN-865
> URL: https://issues.apache.org/jira/browse/YARN-865
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: MR-5337.1.patch, YARN-865.1.patch, YARN-865.2.patch,
> YARN-865.3.patch, YARN-865.4.patch, YARN-865.5.patch, YARN-865.6.patch
>
>
> The resource manager web service api to get the list of apps doesn't have a
> query parameter for appTypes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
