[
https://issues.apache.org/jira/browse/YARN-6366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953780#comment-15953780
]
Shane Kumpf commented on YARN-6366:
-----------------------------------
The two remaining checkstyle issues are due to several test methods exceeding
the 150 line limit. These tests are ~250 lines and this patch only modified a
single line in each. I would prefer this refactoring be done in a separate
issue. If others agree with that approach, I can open a new issue for those.
I believe this is ready for review. /cc [~vvasudev] [~jianhe] [~sidharta-s]
> Refactor the NodeManager DeletionService to support additional DeletionTask
> types.
> ----------------------------------------------------------------------------------
>
> Key: YARN-6366
> URL: https://issues.apache.org/jira/browse/YARN-6366
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager, yarn
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: YARN-6366.001.patch, YARN-6366.002.patch,
> YARN-6366.003.patch, YARN-6366.004.patch
>
>
> The NodeManager's DeletionService only supports file based DeletionTask's.
> This makes sense as files (and directories) have been the primary concern for
> clean up to date. With the addition of the Docker container runtime, addition
> types of DeletionTask are likely to be required, such as deletion of docker
> container and images. See YARN-5366 and YARN-5670. This issue is to refactor
> the DeletionService to support additional DeletionTask's.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
