[
https://issues.apache.org/jira/browse/YARN-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959510#comment-15959510
]
Billie Rinaldi commented on YARN-6405:
--------------------------------------
[~jianhe], thanks for the patch. Here are some comments:
- I don't think we should have a config file cache for each component /
ProviderRole. The cache should be at the application level, for example in
ProviderUtils. It's keyed on the src_file, which is a file in HDFS that can be
shared by all roles.
- Instead of adding a new HADOOP_XML_TEMPLATE type, could we do if (type is
HADOOP_XML and src_file is not null)?
- Why switch APP_NAME to SERVICE_NAME?
- I am not sure the AppState changes will work without having tests, especially
the switch to a single ProviderRole for unique components. Possibly getting
YARN-6335 committed will help us find new AppState bugs. We also need to make
sure strict placement for unique components will still work, as this is
required for apps like ZooKeeper that do not write their data to HDFS.
> Improve configuring services through REST API
> ---------------------------------------------
>
> Key: YARN-6405
> URL: https://issues.apache.org/jira/browse/YARN-6405
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-6405.yarn-native-services.01.patch,
> YARN-6405.yarn-native-services.02.patch,
> YARN-6405.yarn-native-services.03.patch,
> YARN-6405.yarn-native-services.04.patch
>
>
> YARN-4793 defined various ways that user can config services through the
> configuration section of the REST API. But, some semantics are not yet
> supported in the back-end server (AM). YARN-6255 has done some work, this
> jira is to complete this task - support configuring services through REST API
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
