[ 
https://issues.apache.org/jira/browse/YARN-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710149#comment-13710149
 ] 

Hadoop QA commented on YARN-927:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12592595/YARN-927.3.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:

                  org.apache.hadoop.yarn.client.api.impl.TestAMRMClient

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/1499//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1499//console

This message is automatically generated.
                
> Change ContainerRequest to not have more than 1 container count and remove 
> StoreContainerRequest
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-927
>                 URL: https://issues.apache.org/jira/browse/YARN-927
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: YARN-927.1.patch, YARN-927.2.patch, YARN-927.3.patch
>
>
> The downside is having to use more than 1 container request when requesting 
> more than 1 container at * priority. For most other use cases that have 
> specific locations we anyways need to make multiple container requests. This 
> will also remove unnecessary duplication caused by StoredContainerRequest. It 
> will make the getMatchingRequest() always available and easy to use 
> removeContainerRequest().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to