[jira] [Commented] (YARN-927) Change ContainerRequest to not have more than 1 container count and remove StoreContainerRequest

[Sandy Ryza (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710204#comment-13710204
 ] 

Sandy Ryza commented on YARN-927:
---------------------------------

I've thought about this a little more and I'm no longer opposed to the change. 
I looked over the patch just have a few style nits: 

{code}
for(int i=0; i<numTotalContainers; ++i)
{code}
should be
{code}
for (int i = 0; i < numTotalContainers; ++i)
{code}

refs: http://wiki.apache.org/hadoop/CodeReviewChecklist and 
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141388.html#475

In the following places, spacing should be preserved:
{code}
       addResourceRequest(req.getPriority(), rack, req.getCapability(),
-          req.getContainerCount(), req, true);
+            req, true);
{code}

{code}
       addResourceRequest(req.getPriority(), rack, req.getCapability(),
-          req.getContainerCount(), req, req.getRelaxLocality());
+            req, req.getRelaxLocality());
{code}

{code}

-    decResourceRequest(req.getPriority(), ResourceRequest.ANY, 
req.getCapability(),
-        req.getContainerCount(), req);
+    decResourceRequest(req.getPriority(), ResourceRequest.ANY, 
+                       req.getCapability(), req);
{code}

{code}
-    addResourceRequest(req.getPriority(), ResourceRequest.ANY, 
req.getCapability(),
-        req.getContainerCount(), req, req.getRelaxLocality());
+    addResourceRequest(req.getPriority(), ResourceRequest.ANY, 
+                    req.getCapability(), req, req.getRelaxLocality());
{code}
                
> Change ContainerRequest to not have more than 1 container count and remove 
> StoreContainerRequest
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-927
>                 URL: https://issues.apache.org/jira/browse/YARN-927
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: YARN-927.1.patch, YARN-927.2.patch, YARN-927.3.patch
>
>
> The downside is having to use more than 1 container request when requesting 
> more than 1 container at * priority. For most other use cases that have 
> specific locations we anyways need to make multiple container requests. This 
> will also remove unnecessary duplication caused by StoredContainerRequest. It 
> will make the getMatchingRequest() always available and easy to use 
> removeContainerRequest().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira