[ 
https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987166#comment-15987166
 ] 

Vrushali C commented on YARN-6375:
----------------------------------

+1 Thanks [~varun_saxena] for the patch.

Yes, I think we would need some way of identifying the metric type (gauge vs 
counter) but that is outside the scope of this jira. I do agree that we don't 
want to aggregate all values all the time, so let's go ahead with this patch.

I will try to commit this shortly. 

> App level aggregation should not consider metric values reported in the 
> previous aggregation cycle
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6375
>                 URL: https://issues.apache.org/jira/browse/YARN-6375
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-6375-YARN-5355.01.patch
>
>
> Currently app level aggregation is done every 15 seconds.
> And we consider last reported metric value for each entity belonging to an 
> app for aggregation.
> We however merely update the corresponding metric values for the entity on 
> put. We never remove the entries.
> But it is possible that multiple entities finish during lifetime of an 
> application. We however continue to consider them till the end.
> We should however not consider metric values of entities unless reported 
> within the 15 second period.
> Consider containers. For a long running app, several containers would start 
> and end at various times during the lifetime of an app.
> To consider metrics for all the containers throughout the lifetime of app, 
> hence wont be correct.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to