[
https://issues.apache.org/jira/browse/YARN-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989521#comment-15989521
]
Vrushali C commented on YARN-6375:
----------------------------------
Hi [~varun_saxena]
I noticed some checkstyle issues in the new test code in the patch. Will it be
okay for you to fix those?
{code}
[ERROR]
src/test/java/org/apache/hadoop/yarn/server/timelineservice/collector/TestTimelineCollector.java:[218]
(indentation) Indentation: 'method def modifier' have incorrect indentation
level 9, expected level should be one of the following: 6, 8, 10.
[ERROR]
src/test/java/org/apache/hadoop/yarn/server/timelineservice/collector/TestTimelineCollector.java:[220]
(indentation) Indentation: 'method def' child have incorrect indentation level
11, expected level should be one of the following: 8, 10, 12.
[ERROR]
src/test/java/org/apache/hadoop/yarn/server/timelineservice/collector/TestTimelineCollector.java:[222]
(indentation) Indentation: 'method def rcurly' have incorrect indentation
level 9, expected level should be one of the following: 6, 8, 10.
[ERROR]
src/test/java/org/apache/hadoop/yarn/server/timelineservice/collector/TestTimelineCollector.java:[229,19]
(whitespace) NoWhitespaceBefore: ';' is preceded with whitespace.
[ERROR]
src/test/java/org/apache/hadoop/yarn/server/timelineservice/collector/TestTimelineCollector.java:[263,19]
(whitespace) NoWhitespaceBefore: ';' is preceded with whitespace.
{code}
thanks
Vrushali
> App level aggregation should not consider metric values reported in the
> previous aggregation cycle
> --------------------------------------------------------------------------------------------------
>
> Key: YARN-6375
> URL: https://issues.apache.org/jira/browse/YARN-6375
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Attachments: YARN-6375-YARN-5355.01.patch
>
>
> Currently app level aggregation is done every 15 seconds.
> And we consider last reported metric value for each entity belonging to an
> app for aggregation.
> We however merely update the corresponding metric values for the entity on
> put. We never remove the entries.
> But it is possible that multiple entities finish during lifetime of an
> application. We however continue to consider them till the end.
> We should however not consider metric values of entities unless reported
> within the 15 second period.
> Consider containers. For a long running app, several containers would start
> and end at various times during the lifetime of an app.
> To consider metrics for all the containers throughout the lifetime of app,
> hence wont be correct.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
