[
https://issues.apache.org/jira/browse/YARN-6560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998641#comment-15998641
]
Yufei Gu commented on YARN-6560:
--------------------------------
Thanks [~wangda] for woking on this. I met the same issue in YARN-5067 and
provided similar solution. Some thoughts for patch v1:
# Why do we need to move the following code considering that {{setConf()}} is
invoked in {{init()}} anyway?
{code}
// runner configuration
getConf().addResource("sls-runner.xml");
// runner
int poolSize = getConf().getInt(SLSConfiguration.RUNNER_POOL_SIZE,
SLSConfiguration.RUNNER_POOL_SIZE_DEFAULT);
SLSRunner.runner.setQueueSize(poolSize);
// <AMType, Class> map
for (Map.Entry e : getConf()) {
String key = e.getKey().toString();
if (key.startsWith(SLSConfiguration.AM_TYPE)) {
String amType = key.substring(SLSConfiguration.AM_TYPE.length());
amClassMap.put(amType, Class.forName(getConf().get(key)));
}
}
{code}
# Do you mind merging {{inti()}} into the constructor since there is only one
line of code in the constructor?
> SLS doesn't honor node total resource specified in sls-runner.xml
> -----------------------------------------------------------------
>
> Key: YARN-6560
> URL: https://issues.apache.org/jira/browse/YARN-6560
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6560.1.patch
>
>
> Now SLSRunner extends ToolRunner, so setConf will be called twice: once in
> the init() of SLSRunner and once in ToolRunner. The later one will overwrite
> the previous one so it won't correctly load sls-runner.xml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
