[
https://issues.apache.org/jira/browse/YARN-6560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008845#comment-16008845
]
Carlo Curino commented on YARN-6560:
------------------------------------
[~wangda] thanks for taking this on. I don't think this does achieve exactly
the same as the previous one when we run SLS via Toolrunner.
In your version you do load the default confs, while the previous one did not
(not sure what's the difference, but it is not the same).
Also couldn't you achieve the same by overriding {{setConf}} as follows?
{code}
@Override
public void setConf(Configuration conf) {
conf.addResource("sls-runner.xml");
super.setConf(conf);
}
{code}
If that works it is a smaller/clearer change I think.
Also just to be safe, can you do a round of runs with {{TestSLSRunner}}
(comment out the {{OLD_RUMEN}} and {{RUMEN}} cases, to see the rest running and
bypassing YARN-6111 issues) and by launching it via various command line
configs, to make sure all is good.
> SLS doesn't honor node total resource specified in sls-runner.xml
> -----------------------------------------------------------------
>
> Key: YARN-6560
> URL: https://issues.apache.org/jira/browse/YARN-6560
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6560.1.patch, YARN-6560.2.patch
>
>
> Now SLSRunner extends ToolRunner, so setConf will be called twice: once in
> the init() of SLSRunner and once in ToolRunner. The later one will overwrite
> the previous one so it won't correctly load sls-runner.xml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
