[ 
https://issues.apache.org/jira/browse/YARN-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999670#comment-15999670
 ] 

Jian He commented on YARN-6306:
-------------------------------

Hi [~asuresh], I did a quick scan,
- wonder why not add the new methods in the AbstractCallbackHandler - we can 
create non-abstract methods with dummy implementation only ?
- containerLaunchContex: typo
{code}
  public abstract void reInitializeContainer(ContainerId containerId,
      ContainerLaunchContext containerLaunchContex, boolean autoCommit)
{code}
- autoCommit in ReInitializeContainerEvevnt is not initialized, and
- ReInitializeContainerEvevnt has a typo 


> NMClient API change for container upgrade
> -----------------------------------------
>
>                 Key: YARN-6306
>                 URL: https://issues.apache.org/jira/browse/YARN-6306
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Arun Suresh
>         Attachments: YARN-6306.001.patch
>
>
> This JIRA is track the addition of Upgrade API (Re-Initialize, Restart, 
> Rollback and Commit) to the NMClient and NMClientAsync



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to