[
https://issues.apache.org/jira/browse/YARN-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008429#comment-16008429
]
Jian He commented on YARN-6306:
-------------------------------
few more comments:
The NMClient#getNodeId API may cause confusion to users as it only works for
cached containers. Should we document this explicitly or have it as a private
API ?
Btw, I had one thought long time ago, do you think it's good to put NodeId as
part of ContainerId.
- The log message is incorrect in a couple of places like below, probably due
to copy and paste
{code}
handler.onRollbackLastReInitializationError(
containerId, RPCUtil.getRemoteException(
"Container " + containerId + " is not started"));
if (containers.get(containerId) == null) {
handler.onCommitLastReInitializationError(
containerId, RPCUtil.getRemoteException(
"Container " + containerId + " is not started"));
{code}
- NMClientImpl#reInitializeContainer, why not put it into the
restartCommitOrRollbackContainer method as others do ?
> NMClient API change for container upgrade
> -----------------------------------------
>
> Key: YARN-6306
> URL: https://issues.apache.org/jira/browse/YARN-6306
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Arun Suresh
> Attachments: YARN-6306.001.patch
>
>
> This JIRA is track the addition of Upgrade API (Re-Initialize, Restart,
> Rollback and Commit) to the NMClient and NMClientAsync
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
