[
https://issues.apache.org/jira/browse/YARN-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001790#comment-16001790
]
Subru Krishnan commented on YARN-5531:
--------------------------------------
Thanks [~botong] for addressing my feedback. The latest patch (v8) LGTM. I only
have a few nits:
* Please do *not* log _Token_ in {{YarnServerSecurityUtils::createRMProxy}}
as it's not safe.
* *rmName* is redundant in {{YarnServerSecurityUtils::createRMProxy}} as the
RM_CLUSTER_ID is already in the conf.
* Based on above comment, we don't need
{{UnmanagedApplicationManager::createRMProxy}}.
* Looks like you missed one of my comments:
bq. UnmanagedAMLauncher::submitAppAndGetAppId can be void.
[~kasha], it'll be good if you take a quick look before I commit.
> UnmanagedAM pool manager for federating application across clusters
> -------------------------------------------------------------------
>
> Key: YARN-5531
> URL: https://issues.apache.org/jira/browse/YARN-5531
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Botong Huang
> Attachments: YARN-5531-YARN-2915.v1.patch,
> YARN-5531-YARN-2915.v2.patch, YARN-5531-YARN-2915.v3.patch,
> YARN-5531-YARN-2915.v4.patch, YARN-5531-YARN-2915.v5.patch,
> YARN-5531-YARN-2915.v6.patch, YARN-5531-YARN-2915.v7.patch,
> YARN-5531-YARN-2915.v8.patch
>
>
> One of the main tenets the YARN Federation is to *transparently* scale
> applications across multiple clusters. This is achieved by running UAMs on
> behalf of the application on other clusters. This JIRA tracks the addition of
> a UnmanagedAM pool manager for federating application across clusters which
> will be used the FederationInterceptor (YARN-3666) which is part of the
> AMRMProxy pipeline introduced in YARN-2884.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
