[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003194#comment-16003194
]
Miklos Szegedi commented on YARN-5301:
--------------------------------------
Thank you for the review [~templedf]. I think, there is no member field hiding
in initializeControllerPathsFromMtab because it is a static function, so it
does not relate to any object members.
In terms of string concatenation there are two sides of the question. The style
side is a theological question, so I do not want to comment on that. Talking
about functionality the compiler instructs us to use + instead of StringBuilder
because of performance. StringUtils.join uses StringBuilder inside, so using it
would be a regression. I think we should use + in all cases with a fixed number
of + operators and use StringUtils.join, when we have variable number of items.
> NM mount cpu cgroups failed on some systems
> -------------------------------------------
>
> Key: YARN-5301
> URL: https://issues.apache.org/jira/browse/YARN-5301
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: sandflee
> Assignee: Miklos Szegedi
> Attachments: YARN-5301.000.patch, YARN-5301.001.patch,
> YARN-5301.002.patch, YARN-5301.003.patch, YARN-5301.004.patch,
> YARN-5301.005.patch, YARN-5301.006.patch, YARN-5301.007.patch,
> YARN-5301.008.patch, YARN-5301.009.patch, YARN-5301.010.patch
>
>
> on ubuntu with linux kernel 3.19, , NM start failed if enable auto mount
> cgroup. try command:
> ./bin/container-executor --mount-cgroups yarn-hadoop cpu=/cgroup/cpu fail
> ./bin/container-executor --mount-cgroups yarn-hadoop cpu,cpuacct=/cgroup/cpu
> succ
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
