[
https://issues.apache.org/jira/browse/YARN-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014696#comment-16014696
]
Wangda Tan commented on YARN-6547:
----------------------------------
Thanks [~curino], I tried to run tests with the patch, all passed except RUMEN.
Only one comment:
Could you move changes to JvmMetrics to a separate public static methods like
reregister, etc. and mark it to VisibleToTest? I'm not sure if the changes is
safe or not, moving such test-only code to a separate methods should be better.
Beyond that, patch looks good.
> Enhance SLS-based tests leveraging invariant checker
> ----------------------------------------------------
>
> Key: YARN-6547
> URL: https://issues.apache.org/jira/browse/YARN-6547
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Attachments: YARN-6547.v0.patch, YARN-6547.v1.patch
>
>
> We can leverage {{InvariantChecker}}s to provide a more thorough validation
> of SLS-based tests. This patch introduces invariants checking during and at
> the end of the run.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
