[ 
https://issues.apache.org/jira/browse/YARN-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020182#comment-16020182
 ] 

Wangda Tan commented on YARN-6245:
----------------------------------

[~daryn],

Discussed with [~jlowe] offline, it looks like a great idea. It automatically 
use light PB while doing internal computations.

bq. ...  which converts the lightweight to a pb impl as required. 

Not sure if this convert lightweight Resource instance permanently or 
temporarily, it's better to optimize the case which 
{{ProtoUtils.convertToProtoFormat(Resource)}} invoked many times on a same 
Resource object reference, ideally conversion should only happen once. 

> Add FinalResource object to reduce overhead of Resource class instancing
> ------------------------------------------------------------------------
>
>                 Key: YARN-6245
>                 URL: https://issues.apache.org/jira/browse/YARN-6245
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>         Attachments: observable-resource.patch, 
> YARN-6245.preliminary-staled.1.patch
>
>
> There're lots of Resource object creation in YARN Scheduler, since Resource 
> object is backed by protobuf, creation of such objects is expensive and 
> becomes bottleneck.
> To address the problem, we can introduce a FinalResource (Is it better to 
> call it ImmutableResource?) object, which is not backed by PBImpl. We can use 
> this object in frequent invoke paths in the scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to