[ 
https://issues.apache.org/jira/browse/YARN-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036534#comment-16036534
 ] 

Manikandan R commented on YARN-6467:
------------------------------------

Thanks [~Naganarasimha] for review. Attaching .003.patch for changes.

1. Taken care. 
2. Renamed in both QueueMetrics and CSQueueMetrics.
3. Currently it not being used. Hence removed the method. It has been added as 
part of YARN-4538
4. Metrics like allocatedContainers and aggregateContainersAllocated are being 
manipulated only based on partition check - meaning only for "default" 
partition. For that matter, even for other metrics like pendingMB, 
pendingVCores are also being modified in the same way. Do we need to capture 
these info in this JIRA for our future reference?
5. Taken care as part on point no.1 . Aren't we referring the same?
6,7,8: Taken care.

Also verified that Checkstyle issues and Junit failures are not related to this 
patch.

> CSQueueMetrics needs to update the current metrics for default partition only
> -----------------------------------------------------------------------------
>
>                 Key: YARN-6467
>                 URL: https://issues.apache.org/jira/browse/YARN-6467
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>    Affects Versions: 2.8.0, 2.7.3, 3.0.0-alpha2
>            Reporter: Naganarasimha G R
>            Assignee: Manikandan R
>         Attachments: YARN-6467.001.patch, YARN-6467.001.patch, 
> YARN-6467.002.patch, YARN-6467.003.patch
>
>
> As a followup to YARN-6195, we need to update existing metrics to only 
> default Partition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to