[ 
https://issues.apache.org/jira/browse/YARN-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056658#comment-16056658
 ] 

ASF GitHub Bot commented on YARN-6668:
--------------------------------------

Github user haibchen commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/241#discussion_r123063565
  
    --- Diff: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
 ---
    @@ -37,7 +37,7 @@
     @Public
     @Evolving
     public abstract class ResourceCalculatorProcessTree extends Configured {
    -  static final Log LOG = LogFactory
    +  static protected final Log LOG = LogFactory
    --- End diff --
    
    can we put protected in front of static just to be consistent with the code 
style?


> Use cgroup to get container resource utilization
> ------------------------------------------------
>
>                 Key: YARN-6668
>                 URL: https://issues.apache.org/jira/browse/YARN-6668
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Haibo Chen
>            Assignee: Miklos Szegedi
>
> Container Monitor relies on proc file system to get container resource 
> utilization, which is not as efficient as reading cgroup accounting. We 
> should in NM, when cgroup is enabled, read cgroup stats instead. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to