[ https://issues.apache.org/jira/browse/YARN-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065226#comment-16065226 ]
Junping Du commented on YARN-2919: ---------------------------------- Thanks [~Naganarasimha] for contributing the patch. Latest patch looks good to me. Just a minor comments for DelegationTokenRenewer, if token is cancelling, shall we log something different than "The token was removed already."? Other looks fine to me. btw, does failed tests related to the patch? If not, do we have some JIRA to track them? > Potential race between renew and cancel in DelegationTokenRenwer > ----------------------------------------------------------------- > > Key: YARN-2919 > URL: https://issues.apache.org/jira/browse/YARN-2919 > Project: Hadoop YARN > Issue Type: Bug > Components: security > Affects Versions: 2.6.0 > Reporter: Karthik Kambatla > Assignee: Naganarasimha G R > Priority: Critical > Attachments: YARN-2919.002.patch, YARN-2919.003.patch, > YARN-2919.004.patch, YARN-2919.20141209-1.patch > > > YARN-2874 fixes a deadlock in DelegationTokenRenewer, but there is still a > race because of which a renewal in flight isn't interrupted by a cancel. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org