[
https://issues.apache.org/jira/browse/YARN-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077001#comment-16077001
]
Junping Du commented on YARN-2919:
----------------------------------
Thanks for additional review, [~jianhe]!
bq. there are some behavior changes, the return value of renew method was
supposed to be the expiration time, now '-1' is returned as an error code,
which old program does not understand - old program was expecting an exception
if renew fails.
Oh. I could miss that. "-1" is something dangerous as caller will use this
value as expire time, etc., just like: DelegationTokenRenewer.renew() or
DelegationTokenFetcher.renewTokens(). I think we should throw IOException
instead given the behavior should be failed to renew (due to token get
cancelling), and also most callers should handle IOException explicitly for
renew failure cases.
> Potential race between renew and cancel in DelegationTokenRenwer
> -----------------------------------------------------------------
>
> Key: YARN-2919
> URL: https://issues.apache.org/jira/browse/YARN-2919
> Project: Hadoop YARN
> Issue Type: Bug
> Components: security
> Affects Versions: 2.6.0
> Reporter: Karthik Kambatla
> Assignee: Naganarasimha G R
> Priority: Critical
> Attachments: YARN-2919.002.patch, YARN-2919.003.patch,
> YARN-2919.004.patch, YARN-2919.005.patch, YARN-2919.20141209-1.patch
>
>
> YARN-2874 fixes a deadlock in DelegationTokenRenewer, but there is still a
> race because of which a renewal in flight isn't interrupted by a cancel.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
