[
https://issues.apache.org/jira/browse/YARN-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094452#comment-16094452
]
Varun Saxena commented on YARN-6130:
------------------------------------
Thanks [~rohithsharma] for the review.
bq. newly added proto i.e AMCollectorInfoProto has rm_identifier and version.
Why does these required for AM?
The intention here is to avoid updating the token in AM UGI on every allocate
response. We can potentially cache the RMID and version to ensure that the
version of token coming from RM is same as the one already updated by AM in its
UGI. Thoughts?
bq. I see AppCollectorData#hasSameVersion added. Where it will be used? Trying
to understanding its usage.
Not required. Was planning to use it for use case above. A similar check would
be required in AMCollectorInfo instead.
bq. IAC, collector_address and token can be kept in separate proto may be name
it as generic i.e CollectorInfo or any other?
Ok. We can name it as CollectorInfo instead of AMCollectorInfo.
bq. for every heartbeat, we are creating AMCollectorInfo object. Could it be
cached?
Yes, it can be in RMAppImpl.
> [ATSv2 Security] Generate a delegation token for AM when app collector is
> created and pass it to AM via NM and RM
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6130
> URL: https://issues.apache.org/jira/browse/YARN-6130
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6130-YARN-5355.01.patch,
> YARN-6130-YARN-5355.02.patch, YARN-6130-YARN-5355.03.patch,
> YARN-6130-YARN-5355.04.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]