[
https://issues.apache.org/jira/browse/YARN-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098275#comment-16098275
]
Varun Saxena commented on YARN-6130:
------------------------------------
Thanks [~jianhe] and [~rohithsharma] for reviews. Sorry could not reply earlier.
bq. The AllocateResponse#newInstance method may be not needed. I think if we
have the Builder pattern, we don’t need to keep on adding newInstance methods
anymore
Ok.
bq. Even without rmIdentifies, if token is updated with same rm_identifiers
then AM has to update it right? Am I missing any particular scenario?
I was thinking of caching the rm id and version which came when token was last
updated in MapReduce AM. So that we can match against it.
This was to get rid of unncessary adding of tokens in UGI if the said token has
already been updated. If the token service already exists in tokenMap, which
would be true just about everytime, while adding token, in
Credentials#addToken, we iterate over all the available tokens.
This was a small optimization for that. Assuming AM may not have too many
tokens so iterating over the token map may not be that costly though.
Thoughts?
> [ATSv2 Security] Generate a delegation token for AM when app collector is
> created and pass it to AM via NM and RM
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6130
> URL: https://issues.apache.org/jira/browse/YARN-6130
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6130-YARN-5355.01.patch,
> YARN-6130-YARN-5355.02.patch, YARN-6130-YARN-5355.03.patch,
> YARN-6130-YARN-5355.04.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
