[
https://issues.apache.org/jira/browse/YARN-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094990#comment-16094990
]
Joep Rottinghuis commented on YARN-6850:
----------------------------------------
+1 looks good.
Note that for data written before this patch that when timeseries are retrieved
the right data isn't returned.
This is still alpha, so only a few of us testing should be impacted. The TTL
should work properly after this.
We should merge this to trunk as it will change how data is retrieved.
We should consider adding something to the release notes wrt. incompatability
between alpha and this latest drop.
When really needed we could write a (MR) job to read all the all data and
re-write it is there is a use-case that has already started to collect metrics
and the original data needs to absolutely be retrieved. Given the alpha status
I think this change is acceptable to fix the TTL functionality.
> Ensure that supplemented timestamp is stored only for flow run metrics
> ----------------------------------------------------------------------
>
> Key: YARN-6850
> URL: https://issues.apache.org/jira/browse/YARN-6850
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Vrushali C
> Assignee: Varun Saxena
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6850-YARN-5355.01.patch
>
>
> In timeline service v2, ColumnHelper#getPutTimestamp supplements the
> timestamp and is called by ColumnHelper#store. This is not conditional and
> called for every put.
> We need to ensure that the cell timestamps for metrics in entity and
> application (and sub application) tables are "correct" timestamps since we
> will be enabling TTLs for these cells.
> The supplemented timestamp is to be used only in the flow run table by the
> coprocessor which intercepts all reads & writes to cells in this table. It
> looks at the supplemented timestamp to figure out which app id this
> particular cell belongs to. This is done in order to ensure no collision
> occurs when two apps belonging to same flow run write the same metric at the
> same timestamp.
> Discovered in the discussion in YARN-4455
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
