[
https://issues.apache.org/jira/browse/YARN-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097359#comment-16097359
]
Rohith Sharma K S commented on YARN-6850:
-----------------------------------------
+1 LGTM
> Ensure that supplemented timestamp is stored only for flow run metrics
> ----------------------------------------------------------------------
>
> Key: YARN-6850
> URL: https://issues.apache.org/jira/browse/YARN-6850
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Vrushali C
> Assignee: Varun Saxena
> Labels: yarn-5355-merge-blocker
> Attachments: YARN-6850-YARN-5355.01.patch
>
>
> In timeline service v2, ColumnHelper#getPutTimestamp supplements the
> timestamp and is called by ColumnHelper#store. This is not conditional and
> called for every put.
> We need to ensure that the cell timestamps for metrics in entity and
> application (and sub application) tables are "correct" timestamps since we
> will be enabling TTLs for these cells.
> The supplemented timestamp is to be used only in the flow run table by the
> coprocessor which intercepts all reads & writes to cells in this table. It
> looks at the supplemented timestamp to figure out which app id this
> particular cell belongs to. This is done in order to ensure no collision
> occurs when two apps belonging to same flow run write the same metric at the
> same timestamp.
> Discovered in the discussion in YARN-4455
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]