[
https://issues.apache.org/jira/browse/YARN-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alejandro Abdelnur updated YARN-937:
------------------------------------
Attachment: YARN-937.patch
Oops, sorry missed Vinod's comments before, uploading new patch that addresses
them (and Bikas' latest comments as well).
A couple things to note:
* On adding a new ApplicationReport.newInstance() signature for this. This
method is only used from testcases, I'd rather not proliferate on @Private
methods when one is enough.
* Changed the jobtoken file creation to do use FileUtils.chmod() and the file
creation to be an append (the temp is created with zero bytes). Then we don't
have a race condition.
* Limiting the return window of the AMRM token to when the application is in
ACCEPTED state. This is a stable state before the uAM registers with the
scheduler, thus the uAM can save the tokens for failover logic if desired.
I think the only outstanding comment is Bikas' "Unless I am missing something,
the MR AM code did not have to change to make this translation.... "
Managed AMs do something a bit incorrect, from {{RMAppAttemptImpl}}:
{code}
// normally the client should set the service after acquiring the
// token, but this token is directly provided to the AMs
SecurityUtil.setTokenService(amRmToken, serviceAddr);
{code}
> Fix unmanaged AM in non-secure/secure setup post YARN-701
> ---------------------------------------------------------
>
> Key: YARN-937
> URL: https://issues.apache.org/jira/browse/YARN-937
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.1.0-beta
> Reporter: Arun C Murthy
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 2.1.0-beta
>
> Attachments: YARN-937.patch, YARN-937.patch, YARN-937.patch,
> YARN-937.patch, YARN-937.patch
>
>
> Fix unmanaged AM in non-secure/secure setup post YARN-701 since app-tokens
> will be used in both scenarios.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
