[
https://issues.apache.org/jira/browse/YARN-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alejandro Abdelnur updated YARN-937:
------------------------------------
Attachment: YARN-937.patch
Thanks Bikas, addressed your comments:
bq. Token can be null at this point, right? ....
Now adding a precondition check that fails if the AM state is not in ACCEPTED
state.
bq. Also, any particular reason the token file is create in temp dir rather
than current dir?...
Done.
bq. It might be better to compare currentAttempt.getState() ==
RMAppAttemptState.LAUNCHED...
Done.
Still I don't think unmanaged AM retries should be a concern of the RM. if the
uAM supports that, it should be completely transparent to the RM even from
state perspective. In other words, the RM should not be aware the uAM has
failed and is retrying if the application is still valid.
bq. Rest looks good except for the followin about which I am not sure.
This could be avoided if the ApplicationReport returns the scheduler port,
which it does not today. Because of this, the clien must pick up from its
configuration the scheduler port.
Regarding RM HA, as I mentioned before, if we follow the same pattern used by
HDFS HA, then all HOSTNAME:PORT entries in the configurations will become
logical names that are resolved to the active HOSTNAME:PORT transparently by
the RPC client retry policy for HA (if I remember correctly).
> Fix unmanaged AM in non-secure/secure setup post YARN-701
> ---------------------------------------------------------
>
> Key: YARN-937
> URL: https://issues.apache.org/jira/browse/YARN-937
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.1.0-beta
> Reporter: Arun C Murthy
> Assignee: Alejandro Abdelnur
> Priority: Blocker
> Fix For: 2.1.0-beta
>
> Attachments: YARN-937.patch, YARN-937.patch, YARN-937.patch,
> YARN-937.patch, YARN-937.patch, YARN-937.patch
>
>
> Fix unmanaged AM in non-secure/secure setup post YARN-701 since app-tokens
> will be used in both scenarios.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
