[
https://issues.apache.org/jira/browse/YARN-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114160#comment-16114160
]
Sunil G commented on YARN-6726:
-------------------------------
Sorry for pitching in late here:
Some minor comments:
# It will be better if we can write to LOGFILE ot ERRORFILE regarding
{{regex_match}} failure if any from {{validate_docker_image_name}} method. It
could help us getting for information regarding regex failure if any.
# A suggestion. {{validate_docker_image_name}} could also take {{regex_str}} as
input. In that case we can use this method for any future regex matching.
# validate_container_id could take const param
# I think i am missing something. Could you please to share why we need a
prefix of UTILS here, is this a standard. {{#ifndef _UTILS_STRING_UTILS_H_}}
> Fix issues with docker commands executed by container-executor
> --------------------------------------------------------------
>
> Key: YARN-6726
> URL: https://issues.apache.org/jira/browse/YARN-6726
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: YARN-6726.001.patch, YARN-6726.002.patch
>
>
> docker inspect, rm, stop, etc are issued through container-executor. Commands
> other than docker run are not functioning properly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
