[
https://issues.apache.org/jira/browse/YARN-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114373#comment-16114373
]
Manikandan R commented on YARN-6934:
------------------------------------
[~dan...@cloudera.com]
While making an attempt to do required changes, had come across below lines
{code}if (DISALLOWED_NAMES.contains(resourceName)) {
throw new YarnRuntimeException(
"Resource type cannot be named '" + resourceName
+ "'. That name is disallowed.");
}{code}
in initializeResourcesMap() method in ResourceUtils.java. I am not sure about
the use of checkMandatatoryResources() method when above block of code doesn't
allow to proceed further. Should we need to make a call to
checkMandatatoryResources() after addManadtoryResources() similar to calls in
getNodeResourceInformation() ?
I may be wrong, Please help me to understand.
In addition, we will need to fix typo issues in method names as well. for ex,
addManadtoryResources()
> ResourceUtils.checkMandatoryResources() should also ensure that no min or max
> is set for vcores or memory
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-6934
> URL: https://issues.apache.org/jira/browse/YARN-6934
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Labels: newbie++
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
