[
https://issues.apache.org/jira/browse/YARN-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114520#comment-16114520
]
Daniel Templeton commented on YARN-6934:
----------------------------------------
See YARN-6933. :)
That whole block of code can be removed. {{checkMandatoryResources()}} does
the same check, but more descriptively. {{checkMandatoryResources()}} and
{{addMandatoryResources()}} are called at the bottom of
{{initializeResourcesMap()}}, so taking out the extra check is fine.
Good catch on the order of {{checkMandatoryResources()}} and
{{addMandatoryResources()}} being different in
{{getNodeResourceInformation()}}. You should probably swap them to match the
order in {{initializeResourcesMap()}}.
> ResourceUtils.checkMandatoryResources() should also ensure that no min or max
> is set for vcores or memory
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-6934
> URL: https://issues.apache.org/jira/browse/YARN-6934
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Labels: newbie++
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
