[
https://issues.apache.org/jira/browse/YARN-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130317#comment-16130317
]
Shane Kumpf commented on YARN-6930:
-----------------------------------
Thanks for the review, [~ebadger].
{quote}
The findbugs isn't related to this JIRA, butI think it's something that we
should fix.
{quote}
See YARN-6515. YARN-6968 has been created to track fixing the issue, but I
expect we'll remove the reference all together once whitelisted mounts are
available.
{quote}
Is it ok to import static variables one by one or should we just import
YarnConfiguration and reference the variables specifically?
{quote}
Given line length limits and how long some of the config options have become,
IMO, it improves readability, but I'll let others comment if there is a strong
opinion.
{quote}
I also wonder whether it would be better/cleaner to iterate through
allowedRuntimes and allocate the new objects by class name via reflection
instead of hard-coding all of them
{quote}
I've always tried to reserve reflection for cases where I don't know a class
and its functionality at compile time. In this case we do. Again, if there is a
strong opinion that the trade off is worth it, I can pursue a patch that
leverages reflection.
> Admins should be able to explicitly enable specific LinuxContainerRuntime in
> the NodeManager
> --------------------------------------------------------------------------------------------
>
> Key: YARN-6930
> URL: https://issues.apache.org/jira/browse/YARN-6930
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Shane Kumpf
> Attachments: YARN-6930.001.patch, YARN-6930.002.patch,
> YARN-6930.003.patch
>
>
> Today, in the java land, all LinuxContainerRuntimes are always enabled when
> using LinuxContainerExecutor and the user can simply invoke anything that
> he/she wants - default, docker, java-sandbox.
> We should have a way for admins to explicitly enable only specific runtimes
> that he/she decides for the cluster. And by default, we should have
> everything other than the default one disabled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
