[
https://issues.apache.org/jira/browse/YARN-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145597#comment-16145597
]
Jason Lowe commented on YARN-6930:
----------------------------------
Thanks for updating the patch!
In addition to Eric's comment, it would be nice if we identified which word in
the config value wasn't recognized in this error handling. The code should be
catching inside the for loop so it knows which value was bad and can report it.
{code}
try {
for (String configuredRuntime : configuredRuntimes) {
allowedRuntimes.add(
LinuxContainerRuntimeType.valueOf(configuredRuntime.toUpperCase()));
}
} catch (IllegalArgumentException e) {
throw new ContainerExecutionException("Invalid runtime configuration for "
+ LINUX_CONTAINER_RUNTIME_ALLOWED_RUNTIMES);
}
{code}
Otherwise patch looks good overall.
> Admins should be able to explicitly enable specific LinuxContainerRuntime in
> the NodeManager
> --------------------------------------------------------------------------------------------
>
> Key: YARN-6930
> URL: https://issues.apache.org/jira/browse/YARN-6930
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Shane Kumpf
> Attachments: YARN-6930.001.patch, YARN-6930.002.patch,
> YARN-6930.003.patch, YARN-6930.004.patch, YARN-6930.005.patch
>
>
> Today, in the java land, all LinuxContainerRuntimes are always enabled when
> using LinuxContainerExecutor and the user can simply invoke anything that
> he/she wants - default, docker, java-sandbox.
> We should have a way for admins to explicitly enable only specific runtimes
> that he/she decides for the cluster. And by default, we should have
> everything other than the default one disabled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
