[
https://issues.apache.org/jira/browse/YARN-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133340#comment-16133340
]
Daniel Templeton commented on YARN-7043:
----------------------------------------
My comments:
# Why the additional casts in {{DRC#multiplyAndNormalize}}?
# All those new _throws_ clauses show include {{@throws}} tags in the javadocs
# I think it might be nice to have
{{checkAndThrowExceptionWhenFeatureDisabled()}} throw a subclass of
{{YarnException}} that's specific to the situation, like {{FeatureNotEnabled}}
or {{ServiceNotActive}} or some such.
# The log messages in {{AbstractYarnScheduler}} should be more explicit and
actionable. Tell the admin what happened and what they should do about it.
> Cleanup ResourceProfileManager
> ------------------------------
>
> Key: YARN-7043
> URL: https://issues.apache.org/jira/browse/YARN-7043
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Priority: Critical
> Attachments: YARN-7043.YARN-3926.001.patch,
> YARN-7043.YARN-3926.002.patch
>
>
> Several cleanups we can do for ResourceProfileManager:
> 1) Move GetResourceTypesInfo from profile manager to ResourceUtils.
> 2) Move logics to check profile enabled, etc. from ClientRMService to
> ResourceUtils.
> 3) Throw exception when resource profile is disabled and method accessed by
> other modules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
