[
https://issues.apache.org/jira/browse/YARN-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133600#comment-16133600
]
Wangda Tan commented on YARN-7043:
----------------------------------
Thanks [~templedf],
bq. All those new throws clauses show include @throws tags in the javadocs
Done
bq. I think it might be nice to have
checkAndThrowExceptionWhenFeatureDisabled() throw a subclass of YarnException
that's specific to the situation, like FeatureNotEnabled or ServiceNotActive or
some such.
Done, and I added throws javadocs in the YarnClient API and
ApplicationClientProtocol API
bq. The log messages in AbstractYarnScheduler
Since it includes error message of
{{checkAndThrowExceptionWhenFeatureDisabled}}, I updated
{{checkAndThrowExceptionWhenFeatureDisabled}}, included configs to change in
the error message.
Updating ver.3 patch.
> Cleanup ResourceProfileManager
> ------------------------------
>
> Key: YARN-7043
> URL: https://issues.apache.org/jira/browse/YARN-7043
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Priority: Critical
> Attachments: YARN-7043.YARN-3926.001.patch,
> YARN-7043.YARN-3926.002.patch
>
>
> Several cleanups we can do for ResourceProfileManager:
> 1) Move GetResourceTypesInfo from profile manager to ResourceUtils.
> 2) Move logics to check profile enabled, etc. from ClientRMService to
> ResourceUtils.
> 3) Throw exception when resource profile is disabled and method accessed by
> other modules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
