[
https://issues.apache.org/jira/browse/YARN-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137014#comment-16137014
]
Billie Rinaldi commented on YARN-7050:
--------------------------------------
This cleanup patch is looking pretty good; it is mostly deleting classes and
renaming packages / imports, along with removing some unused code. A few
comments
* the SERVICE_HDFS_DIR token value is no longer being set properly (this
probably happened in an earlier patch, but I noticed because the constant used
to construct its value is removed in this patch)
* the new method populatTimelineEntity has a typo in its name
* instead of removing testTimeIntervalLoading, we should modify it to use
parameters that are still in use:
{noformat}
getTimeRange(conf,
YarnServiceConf.CONTAINER_FAILURE_WINDOW,
YarnServiceConf.DEFAULT_CONTAINER_FAILURE_WINDOW_DAYS,
YarnServiceConf.DEFAULT_CONTAINER_FAILURE_WINDOW_HOURS,
YarnServiceConf.DEFAULT_CONTAINER_FAILURE_WINDOW_MINUTES, 0);
{noformat}
* Arguments.java has a bunch of constants that can be removed (including one
with "slider" in it)
* here are remaining files with slider in the name:
{noformat}
./hadoop-assemblies/src/main/resources/assemblies/hadoop-yarn-slider-dist.xml
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/conf/slideram-log4j.properties
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/client/params/SliderActions.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/client/params/SliderAMArgs.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/client/params/SliderAMCreateAction.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/conf/SliderExitCodes.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/conf/SliderKeys.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/exceptions/SliderException.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/rest/SliderURLConnectionFactory.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/utils/SliderFileSystem.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/main/java/org/apache/hadoop/yarn/service/utils/SliderUtils.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core/src/scripts/slider_keytabs.sh
(maybe should be removed)
{noformat}
* there are still usages of "slider" in many of the classes (in comments,
constants method names etc.). We can identify the remaining usages once the
files above have been refactored. I think the most critical ones are in
YarnServiceConf, slideram-log4j.properties, and SliderKeys.java (which contains
various slider file/directory/property constants).
> Post cleanup after YARN-6903
> ----------------------------
>
> Key: YARN-7050
> URL: https://issues.apache.org/jira/browse/YARN-7050
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-7050.yarn-native-services.01.patch,
> YARN-7050.yarn-native-services.02.patch,
> YARN-7050.yarn-native-services.03.patch,
> YARN-7050.yarn-native-services.04.patch,
> YARN-7050.yarn-native-services.05.patch,
> YARN-7050.yarn-native-services.06.patch
>
>
> This jira tries to remove some old code, and moves dependency classes to the
> new package, and also some other side changes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
